This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
tooltip aria watchers #10157
Copy link
Copy link
Closed
Labels
has: Pull RequestA PR has been created to address this issueA PR has been created to address this issueneeds: feedbackThe issue creator or community need to respond to questions in this issueThe issue creator or community need to respond to questions in this issueseverity: performanceThis issue causes a significant performance degradationThis issue causes a significant performance degradationseverity: regressionThis issue is related to a regressionThis issue is related to a regression
Description
Pullrequest 7822 https://github.com/angular/material/pull/7822/files was doing such a good work getting rid of many watchers and then there were added the following code that again adds thousand of watchers for my application:
// Updates the aria-label when the element text changes. This watch
// doesn't need to be set up if the element doesn't have any data
// bindings.
if (element.text().indexOf($interpolate.startSymbol()) > -1) {
scope.$watch(function() {
return element.text().trim();
}, addAriaLabel);
}
Metadata
Metadata
Assignees
Labels
has: Pull RequestA PR has been created to address this issueA PR has been created to address this issueneeds: feedbackThe issue creator or community need to respond to questions in this issueThe issue creator or community need to respond to questions in this issueseverity: performanceThis issue causes a significant performance degradationThis issue causes a significant performance degradationseverity: regressionThis issue is related to a regressionThis issue is related to a regression