Skip to content

fix(docs): darkModeControl overwrites document.body.className instead of using classList.add #1930

Open

Description

@sujlcodes

Describe The Bug

In docs/modules/darkMode.mjs (lines 14–17):

if (localStorage.getItem('animate-css')) {
  document.body.className = 'dark';
  darkCheck.checked = true;
}

When initializing dark mode from localStorage, the code sets document.body.className = 'dark' directly rather than calling document.body.classList.add('dark'). This clobbers all other classes that may already be present on <body> (such as layout, accessibility, or browser extension classes). The event listener itself correctly uses classList.add('dark') and classList.remove('dark').

Steps To Reproduce

  1. In the browser console, run localStorage.setItem('animate-css', 'dark').
  2. Add a class to body, e.g. <body class="custom-layout">.
  3. Reload the page and let darkModeControl() run.
  4. Inspect document.body.className.
  5. Notice custom-layout has been erased and replaced with "dark".

Expected Behavior

document.body.classList.add('dark') should be used so existing body classes are preserved ("custom-layout dark").

Screenshots

No response

Desktop

  • OS: Any
  • Browser: Any modern browser

Smartphone

  • Device: Any
  • Browser: Any

Additional Context

Suggested fix:
In docs/modules/darkMode.mjs line 15, change:

document.body.className = 'dark';

to:

document.body.classList.add('dark');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions