Repository navigation
Read the window title only for script transformations - #844
Open
rekram1-node wants to merge 2 commits into
Open
rekram1-node wants to merge 2 commits into
rekram1-node wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, Hex reads the front window's title through Accessibility every 500 ms, for everyone. Titles often hold email subjects, document names, chat names and page titles. Within dictation, only script transformations ever see the title (
windowTitlein their context), so for nearly everyone it's read for nothing.Every title change also counts as a context change. So each one writes a
contextline tolive.ndjson, which is never trimmed: switching a Slack channel or a browser tab adds a line. One real log had 7,620 of these. After #777 they only name the app, so most are the same "Slack" line over and over.Change
dictation::config::reads_window_title()is true when any mode uses a transformation that isn't built in. It's set alongsidereads_browser()whenever settings apply, so it takes effect without a restart.EventReader::current_context, so it doesn't lose it now that context lines are rarer.uses_browsernow also countsbrowser_hostson the Global mode, which is normally empty.Out of scope
live.ndjsonstill has no size limit, and existing lines stay.Verification
cargo fmt --all --checkandscripts/code-shape.py --checkpass.browsers_are_asked_only_when_something_uses_the_pagetest.