Repository navigation
iOS: pause ellipses, Apple Intelligence cleanup, and a speech model choice - #887
Open
kitlangton wants to merge 2 commits into
Open
kitlangton wants to merge 2 commits into
kitlangton wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iPhone dictation: pauses stop splitting sentences, an optional Apple Intelligence punctuation pass, and a choice of speech model, so the three can be compared on a phone.
Before
...at a pause. The formatter treated each dot as a sentence end:there's some... Shared idea there.After
.../…as a pause: mid-text it becomes a space and the next word keeps its lowercase start (I, its contractions and acronyms stay as they are). A trailing one is dropped, and Polished adds its period. Verbatim is unchanged.SystemLanguageModel.defaultis available, on by default). After the formatter, the app runs one FoundationModels pass that only fixes punctuation and capitalization, joining sentences a pause split.cleanup.Tests:
TranscriptFormatterTests(one real dictated sentence through every style),TranscriptCleanupGuardTests, and a live latency test that skips where Apple Intelligence is missing (the simulator here). FoundationModels is weak-linked, so iOS 18 still launches.Read: the cleanup and the speech model are A/B settings. Keep or drop them once they've been tried on a phone.