Performance: inefficient O(N^2) ripgrep callback

Description

Inefficient code:

opencode/packages/core/src/filesystem/search.ts

Lines 41 to 46 in 2db96c9

    
           Effect.sync(() => { 
        
             state.files.push(entry.path) 
        
             const parts = entry.path.split("/") 
        
             parts.slice(0, -1).forEach((_, index) => directories.add(parts.slice(0, index + 1).join("/") + path.sep)) 
        
             state.directories = Array.from(directories) 
        
           }),

Array.from(directories) called per file. So O(files * dirs).

The path split-then-join also seems optimizable to avoid joins.

Plugins

No response

OpenCode version

No response

Steps to reproduce

No response

Screenshot and/or share link

No response

Operating System

No response

Terminal

No response

The per-entry Array.from(directories) plus repeated prefix joins made the initial filesystem scan O(files × directories). Directories now accumulate in place in a set and materialize once per query. The fix and coverage are on the branch of PR #48638.

Fixed on the branch of PR #48638: state.directories is now a Set that accumulates prefixes in place (no per-entry Array.from, no per-prefix re-joins) and is materialized once per query.

The quadratic directory materialization is fixed in v2: the scan accumulates files and directories in Maps, and only materializes candidates when a search runs. Path-prefix split/join operations remain, but the per-file Array.from(directories) is gone.

Navigation Menu

Repository navigation

Performance: inefficient O(N^2) ripgrep callback #37869

Description

Plugins

OpenCode version

Steps to reproduce

Screenshot and/or share link

Operating System

Terminal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	Effect.sync(() => {
	state.files.push(entry.path)
	const parts = entry.path.split("/")
	parts.slice(0, -1).forEach((_, index) => directories.add(parts.slice(0, index + 1).join("/") + path.sep))
	state.directories = Array.from(directories)
	}),

Performance: inefficient O(N^2) ripgrep callback #37869

Description

Description

Plugins

OpenCode version

Steps to reproduce

Screenshot and/or share link

Operating System

Terminal

Activity

AceRothstein71 commented on Sep 17, 2026

AceRothstein71 commented on Sep 17, 2026

neriousy commented on Oct 19, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions