Skip to content

fix: ensure openai 404 errors are retried#10590

Merged
rekram1-node merged 1 commit intoanomalyco:devfrom
tim-smart:codex-retry
Jan 26, 2026
Merged

fix: ensure openai 404 errors are retried#10590
rekram1-node merged 1 commit intoanomalyco:devfrom
tim-smart:codex-retry

Conversation

@tim-smart
Copy link
Contributor

What does this PR do?

Closes #10505

How did you verify your code works?

Ran the dev build and testing it against the openai api

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

⚠️ Potential Duplicate Found:

This PR appears to be addressing the same issue as the current PR (#10590). Both are focused on ensuring OpenAI 404 errors are retried. You should verify if PR #10507 has already been merged or is still open, as it may make the current PR redundant.

@tim-smart
Copy link
Contributor Author

The following comment was made by an LLM, it may be inaccurate:

⚠️ Potential Duplicate Found:

This PR appears to be addressing the same issue as the current PR (#10590). Both are focused on ensuring OpenAI 404 errors are retried. You should verify if PR #10507 has already been merged or is still open, as it may make the current PR redundant.

The other PR does not fix the issue

@rekram1-node
Copy link
Collaborator

it seems weird to retry a 404, codex cli doesnt do this either afaik

@tim-smart
Copy link
Contributor Author

it seems weird to retry a 404, codex cli doesnt do this either afaik

Yes codex cli retries 404.

@rekram1-node
Copy link
Collaborator

rekram1-node commented Jan 26, 2026

Ig I didn't see it, looking again

@rekram1-node
Copy link
Collaborator

Ah i see it, weird

@rekram1-node rekram1-node merged commit 837037c into anomalyco:dev Jan 26, 2026
4 checks passed
@rekram1-node
Copy link
Collaborator

Thanks!

@tim-smart
Copy link
Contributor Author

I guess ideally this would be up streamed to ai sdk

@rekram1-node
Copy link
Collaborator

yeah true

xenonwellz pushed a commit to xenonwellz/opencode that referenced this pull request Jan 28, 2026
xenonwellz pushed a commit to xenonwellz/opencode that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If openai responds with a 404 status, retry the request

2 participants