Skip to content

fix(ui): use focus-visible instead of focus to prevent sticky hover effect on click #10651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdotdevin merged 2 commits into from
Jan 26, 2026
Merged

fix(ui): use focus-visible instead of focus to prevent sticky hover effect on click #10651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8baf6fb
fix(ui): use focus-visible instead of focus to prevent sticky hover e…
ProdigyRahul Jan 26, 2026
fb2822d
fix(ui): use focus-visible instead of focus to prevent sticky hover e…
ProdigyRahul Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/src/components/session/session-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export function SessionHeader() {
<Portal mount={mount()}>
<button
type="button"
class="hidden md:flex w-[320px] p-1 pl-1.5 items-center gap-2 justify-between rounded-md border border-border-weak-base bg-surface-raised-base transition-colors cursor-default hover:bg-surface-raised-base-hover focus:bg-surface-raised-base-hover active:bg-surface-raised-base-active"
class="hidden md:flex w-[320px] p-1 pl-1.5 items-center gap-2 justify-between rounded-md border border-border-weak-base bg-surface-raised-base transition-colors cursor-default hover:bg-surface-raised-base-hover focus-visible:bg-surface-raised-base-hover active:bg-surface-raised-base-active"
onClick={() => command.trigger("file.open")}
aria-label={language.t("session.header.searchFiles")}
>
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/pages/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,7 @@ export default function Layout(props: ParentProps) {
<div
data-session-id={props.session.id}
class="group/session relative w-full rounded-md cursor-default transition-colors pl-2 pr-3
hover:bg-surface-raised-base-hover focus-within:bg-surface-raised-base-hover has-[[data-expanded]]:bg-surface-raised-base-hover has-[.active]:bg-surface-base-active"
hover:bg-surface-raised-base-hover [&:has(:focus-visible)]:bg-surface-raised-base-hover has-[[data-expanded]]:bg-surface-raised-base-hover has-[.active]:bg-surface-base-active"
>
<Show
when={hoverEnabled()}
Expand Down Expand Up @@ -1771,7 +1771,7 @@ export default function Layout(props: ParentProps) {
)

return (
<div class="group/session relative w-full rounded-md cursor-default transition-colors pl-2 pr-3 hover:bg-surface-raised-base-hover focus-within:bg-surface-raised-base-hover has-[.active]:bg-surface-base-active">
<div class="group/session relative w-full rounded-md cursor-default transition-colors pl-2 pr-3 hover:bg-surface-raised-base-hover [&:has(:focus-visible)]:bg-surface-raised-base-hover has-[.active]:bg-surface-base-active">
<Show
when={!tooltip()}
fallback={
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
&:hover:not(:disabled) {
background-color: var(--surface-raised-base-hover);
}
&:focus:not(:disabled) {
&:focus-visible:not(:disabled) {
background-color: var(--surface-raised-base-hover);
}
&:active:not(:disabled) {
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/components/icon-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@
/* color: var(--icon-hover); */
/* } */
}
&:focus:not(:disabled) {
background-color: var(--surface-focus);
&:focus-visible:not(:disabled) {
background-color: var(--surface-raised-base-hover);
}
&:active:not(:disabled) {
background-color: var(--surface-raised-base-active);
Expand Down
10 changes: 8 additions & 2 deletions packages/ui/src/components/list.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,14 @@
transition: opacity 0.15s ease;

&:hover:not(:disabled),
&:focus:not(:disabled),
Comment thread
ProdigyRahul marked this conversation as resolved.
&:active:not(:disabled) {
background-color: transparent;
opacity: 0.7;
}
&:focus-visible:not(:disabled) {
background-color: transparent;
opacity: 0.7;
}

&:hover:not(:disabled) [data-slot="icon-svg"] {
color: var(--icon-hover);
Expand Down Expand Up @@ -91,11 +94,14 @@
transition: opacity 0.15s ease;

&:hover:not(:disabled),
&:focus:not(:disabled),
Comment thread
ProdigyRahul marked this conversation as resolved.
&:active:not(:disabled) {
background-color: transparent;
opacity: 0.7;
}
&:focus-visible:not(:disabled) {
background-color: transparent;
opacity: 0.7;
}

&:hover:not(:disabled) [data-slot="icon-svg"] {
color: var(--icon-hover);
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/select.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
}
}

&:not([data-expanded]):focus {
&:not([data-expanded]):focus-visible {
&[data-variant="secondary"] {
background-color: var(--button-secondary-base);
}
Expand Down