fix: show all provider models when no providers connected#11198
Merged
Conversation
When no providers were connected, the model dialog would hide models that were in the recent list, but the recent section wasn't being displayed. This caused models to completely disappear. The filter was checking recentList (which only contained non-favorite recent items) instead of recents (all recent items), causing models to be incorrectly filtered out of the main provider list when the recent section wasn't shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no providers were connected, the model dialog would hide models that were in the recent list, but the recent section wasn't being displayed. This caused models to completely disappear from the dialog.
The filter was checking "recentList" (which only contained non-favorite recent items) instead of "recents" (all recent items), causing models to be incorrectly filtered out of the main provider list when the recent section wasn't shown.
Changes
Fixes: model dialog showing empty when no providers connected