desktop: sqlite migration progress bar #13294
Merged
+197
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
adamdotdevin
approved these changes
Feb 12, 2026
| } | ||
| CommandEvent::Stderr(line_bytes) => { | ||
| let line = String::from_utf8_lossy(&line_bytes); | ||
| tracing::info!("{line}"); |
There was a problem hiding this comment.
Should stderr lines be logged as warnings?
Suggested change
| tracing::info!("{line}"); | |
| tracing::warn!("{line}"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic for tracking sqlite migration progress in Desktop by reading stdout (works by intercepting the CommandEvent stream and emitting Tauri events)