Repository navigation
fix(lsp): handle optional requests to avoid MethodNotFound (-32601) with MATLAB Language Server - #4007
Merged
rekram1-node merged 2 commits intoNov 8, 2025
Conversation
…ith MATLAB Language Server - Add no-op handlers for client/registerCapability and client/unregisterCapability - Implement workspace/workspaceFolders response aligned with initialize root - Add tests using a fake LSP server to cover all three requests Fixes anomalyco#4003
Contributor
|
i think this one should be good to go can u fix the ci failure |
rekram1-node
reviewed
Nov 6, 2025
- Replace no-op handlers to return undefined per maintainer feedback - Apply repository formatting (client and tests)
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
…ith MATLAB Language Server (anomalyco#4007)
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…ith MATLAB Language Server (anomalyco#4007)
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
…ith MATLAB Language Server (anomalyco#4007)
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
…ith MATLAB Language Server (anomalyco#4007)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Handle optional LSP requests to avoid
MethodNotFound(-32601) crashing LSP server (matlab-language-server)Fixes #4003
Summary
client/registerCapabilityandclient/unregisterCapability.workspace/workspaceFoldersresponse aligned with the initialize root.MethodNotFound(-32601) noise and improves interoperability withmatlab-language-server.Motivation
Servers may issue optional LSP requests; unhandled methods cause
MethodNotFounderrors and crashmatlab-language-server. Handling these requests is low-risk and LSP spec-aligned.Changes
connection.listen():connection.onRequest("client/registerCapability", async () => ({} as any))connection.onRequest("client/unregisterCapability", async () => ({} as any))connection.onRequest("workspace/workspaceFolders", async () => [{ name: "workspace", uri: "file://" + input.root }])Tests
packages/opencode/test/fixture/lsp/fake-lsp-server.js.Manual validation
matlab-language-serverviaopencode.json(see LSP client returnsMethodNotFound(-32601) for optional requests (client/registerCapability,workspace/workspaceFolders), causing issues withmatlab-language-server#4003 for configuration details); open a.mfile; verify noMethodNotFound(-32601) for the above methods; diagnostics flow; LSP server does not crash.