Repository navigation
feat: add experimental.continue_loop_on_deny config option - #4729
Merged
rekram1-node merged 2 commits intoDec 14, 2025
Merged
Conversation
Contributor
Author
|
Build issues should be sorted now |
github-actions
Bot
force-pushed
the
dev
branch
from
November 27, 2025 01:29
f8ee907 to
6a9856d
Compare
Contributor
Author
|
Friendly pinging @rekram1-node in case this PR was missed (as per comment on another PR) |
Contributor
|
maybe you can make it an EXPERIMENTAL flag or experimental config option. Could see people wanting ore control and stuff. Also can u name it in the same format of other options |
Contributor
Author
|
@rekram1-node thanks for your feedback! I updated the PR:
|
nalin-singh
pushed a commit
to nalin-singh/opencode
that referenced
this pull request
Dec 17, 2025
…#4729) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
rekram1-node
added a commit
that referenced
this pull request
Dec 27, 2025
Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
Closed
3 tasks
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
…#4729) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
…#4729) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
…#4729) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
…#4729) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
androidand
pushed a commit
to androidand/opencode-skein
that referenced
this pull request
Sep 19, 2026
…#4729) Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the agent loop breaks in the case of a tool deny. It means the error is not automatically sent back to the LLM, and it requires user action to continue.
My preference, and perhaps that of others, is to continue the agent loop and have the error automatically fed back to the LLM.
To support this I added a new configuration option
breakLoopOnToolDenywhich defaults totrue(current behavior). This allows users to change this behavior through their config.Open questions
config.jsonschema? I had some issues getting that sorted locally