Skip to content

refactor(app): use the workspace submenu when moving a missing session - #55724

Merged
opencode-agent[bot] merged 1 commit into
workspace-submenufrom
location-missing-submenu
Oct 15, 2026
Merged

opencode-agent[bot] merged 1 commit into
workspace-submenufrom
location-missing-submenu

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

Stacked on #55665. This updates the "Choose worktree" menu shown when a session's directory is missing so it uses the shared WorkspaceSubmenu.

  • The menu keeps "New worktree" at the top level. Existing worktrees now sit under a "Worktree" submenu, the same layout as the new-session picker.
  • With 10 or more worktrees, the submenu has a search field and a scrolling list. The old menu was a flat list with no search, limited to max-h-80.
  • disabled={move.isPending} replaces the per-item disabled flags. There is no "View all" here.
  • Worktree rows now use outline-worktree instead of workspace-isolated, which matches the picker. Rows no longer have a full-path title tooltip, because the shared submenu shows only the filename.
  • The "Loading" row stays at the top level while the first worktree list is still empty.

Before / After

Desktop web, 1280×640, a session with a missing directory and 14 other worktrees. Screenshots were shared in the review thread.

Testing

  • packages/app: bun typecheck
  • packages/app: e2e/regression/session-location-sync.spec.ts (9 passed). The recovery test now opens the "Worktree" submenu before picking a worktree.

Requested by: @Brendonovich (Brendan via Slack)

@opencode-agent
opencode-agent Bot merged commit 1a51ee6 into workspace-submenu Oct 15, 2026
8 of 9 checks passed
@opencode-agent
opencode-agent Bot deleted the location-missing-submenu branch October 15, 2026 13:38
@opencode-agent

Copy link
Copy Markdown
Contributor Author

Folded into #55665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant