Repository navigation
test(cli): remove flaky managed service environment test - #56272
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks good: this removes only the flaky managed service loads configured environment test, and the file's other tests and helpers are unaffected. bun test test/service.test.ts (25 pass) and bun typecheck in packages/cli both pass on the head.
Public API: unchanged.
As the description says, nothing now checks that serve --service applies the env from the service config. If it comes back, it should poll /api/config until the server is ready instead of making one request right after the registration file appears.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
managed service loads configured environmentfrompackages/cli/test/service.test.ts. It was added in #50907 this morning and has failed CI on unrelated PRs since:snapshot-write-retry, plus #56243 and #56264.It starts
opencode serve --service, waits for the registration file, and makes a singleGET /api/configrequest. The registration file can appear before the server is ready, so that first request sometimes returns 503.This leaves no test that the managed service loads environment variables saved in the service config.
service config manages environment variablesstill covers reading and writing that config.Validation
bun test test/service.test.tsinpackages/cli(25 pass)bun typecheckinpackages/cli