Skip to content

test(cli): remove flaky managed service environment test - #56272

Merged
rekram1-node merged 1 commit into
devfrom
remove-service-env-test
Oct 17, 2026
Merged

rekram1-node merged 1 commit into
devfrom
remove-service-env-test

Conversation

@rekram1-node

Copy link
Copy Markdown
Contributor

Summary

Remove managed service loads configured environment from packages/cli/test/service.test.ts. It was added in #50907 this morning and has failed CI on unrelated PRs since: snapshot-write-retry, plus #56243 and #56264.

It starts opencode serve --service, waits for the registration file, and makes a single GET /api/config request. The registration file can appear before the server is ready, so that first request sometimes returns 503.

This leaves no test that the managed service loads environment variables saved in the service config. service config manages environment variables still covers reading and writing that config.

Validation

  • bun test test/service.test.ts in packages/cli (25 pass)
  • bun typecheck in packages/cli

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: this removes only the flaky managed service loads configured environment test, and the file's other tests and helpers are unaffected. bun test test/service.test.ts (25 pass) and bun typecheck in packages/cli both pass on the head.

Public API: unchanged.

As the description says, nothing now checks that serve --service applies the env from the service config. If it comes back, it should poll /api/config until the server is ready instead of making one request right after the registration file appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant