Repository navigation
fix(core): preserve Permission.Error in FileAccess.Interface - #57823
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
No problems found. The bare Error here meant the global Error, so qualifying it as Permission.Error is correct and only changes types. The packages/core type check still passes, so the existing callers in tool/plugin/* and the tests compile against the narrower error union, and test/file-access.test.ts passes.
Public API: unchanged (internal FileAccess.Interface types only).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FileAccess.Interface.authorizeExternalandFileAccess.Interface.authorizeReadused an unqualifiedErrorin their Effect error unions. Becausefile-access.tsdoes not define a localErrortype alias,Errorresolved toglobalThis.Errorinstead ofPermission.Error, collapsing the error union and widening the typed error channel.Change
Qualify
Permission.ErrorinFileAccess.Interfaceso callers retain the narrow tagged error union fromPermission.Service.assert.Out of scope
FileAccess.authorizeExternalorFileAccess.authorizeRead.