Repository navigation
refactor(core): avoid redundant decode and re-branding in session inbox and projector - #57890
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks sound. I type-checked packages/core and ran the changed tests plus the inbox and session suites; all pass. The removed LifecycleConflict fallback really is unreachable, since row.type is checked before decoding. Building the payloads directly gives the same fields as the old double decode. $type<Agent.ID>() changes only the TypeScript type, not the stored column.
Public API is unchanged (internal packages/core types and table typing only).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SessionInbox.promotedFromMessagedecoded the message row withSessionHistory.decodeMessageRowSync(row)and then ranSchema.decodeUnknownSync(UserPayload)/Schema.decodeUnknownSync(SyntheticPayload)a second time over the already-decodedSessionMessage.UserorSessionMessage.Synthetic(re-validating all file attachments), followed by an unreachableLifecycleConflictfallback.SessionTable.agentinpackages/core/src/session/sql.tswas untyped (text()), requiringAgent.ID.make(row.agent)when reading rows inSessionProjectorandSessionInfo.fromRow.SessionProjectordestructuredidfromencodeMessage(message)and re-branded it withSessionMessage.ID.make(id)instead of usingmessage.iddirectly.Change
Out of scope
SessionInbox.fromRow(which decodes raw JSON column values fromSessionInboxTable).