Skip to content

Allow shared directory to be a symlink#123

Closed
vlfesko wants to merge 1 commit intoansistrano:masterfrom
vlfesko:allow_shared_be_symlink
Closed

Allow shared directory to be a symlink#123
vlfesko wants to merge 1 commit intoansistrano:masterfrom
vlfesko:allow_shared_be_symlink

Conversation

@vlfesko
Copy link
Copy Markdown

@vlfesko vlfesko commented May 16, 2016

Add follow=True to shared directory check to allow shared to be a symlink

@ricardclau
Copy link
Copy Markdown
Member

I think this would break BC in some scenarios... what is the use case for this?

Moreover, this also breaks Ansible < 1.8 for everybody, so generally speaking 👎 unless there is a very good reason to add this extra flag

@vlfesko
Copy link
Copy Markdown
Author

vlfesko commented May 17, 2016

Hi, in my case all 'shared' resources are stored on HDD, as long as project sources and system itself is stored on SSD drive. That's why 'shared' directory is actually symlink.
Nevertheless there are many other workarounds how to setup project to not have 'shared' as a symlink, so never mind. But please consider this option for feature, it is useful in some scenarios. Thx!

@ricardclau
Copy link
Copy Markdown
Member

As I mentioned in other PRs and issues, shared links will possibly be refactored in a future Ansistrano 2.0 branch but we don´t want to break compatibility for now

Thanks for sharing your case as I guess it is relatively common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants