Skip to content

feat: x-shard#881

Closed
Rain120 wants to merge 1 commit into
ant-design:nextfrom
Rain120:feature/next-x-shared
Closed

feat: x-shard#881
Rain120 wants to merge 1 commit into
ant-design:nextfrom
Rain120:feature/next-x-shared

Conversation

@Rain120

@Rain120 Rain120 commented May 29, 2025

Copy link
Copy Markdown
Contributor

🤔 Disscuss about refactor to be v2

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Refactoring V2

I discovered that X has been undergoing a refactoring process to become v2. I feel there is something missing from the Ant Design X v2 tasks.

  • Architecture diagram: how to achieve the components to support the x-sdk
  • Universal utilities package missing, like x-shared
  • What means about x-card, something like offical material or load third party message card?
  • What is the purpose of v2? It involves the reasons for restructuring it.

It's my think about it, please answer them when you are free, Thx.

@coderabbitai

coderabbitai Bot commented May 29, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions

github-actions Bot commented May 29, 2025

Copy link
Copy Markdown
Contributor

Preview is ready

@dosubot dosubot Bot added the enhancement New feature or request label May 29, 2025
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@codecov

codecov Bot commented May 29, 2025

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented May 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.34%. Comparing base (883237f) to head (5aebbd1).
⚠️ Report is 423 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #881   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          66       66           
  Lines        1490     1490           
  Branches      402      385   -17     
=======================================
  Hits         1376     1376           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@afc163

afc163 commented May 30, 2025

Copy link
Copy Markdown
Member

What is x-shared ?

@kimteayon

kimteayon commented May 30, 2025

Copy link
Copy Markdown
Collaborator

Hello, could you introduce x-shard and write rfc in the discussions section

@Rain120

Rain120 commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

About x-shared

This refers to universal tools which do not involve the x-sdk logic, such as

  • base x motion config
    image
  • base x hooks
    image
  • base x theme config
    image
  • common style config
    image

@Div627

Div627 commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

@Rain120 Hi, Thanks for your detailed thoughts on the V2 refactoring!
Since Ant Design X v2.3.0 has already been released, the architecture and components you mentioned (including SDK support and shared utilities) have been finalized and implemented in the current version.
Therefore, we will close this PR as the discussion points are now covered by the latest release. If you find any specific issues with v2.3.0 or have new suggestions, please feel free to open a new issue.
Thanks again for your contribution!

@Div627 Div627 closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants