introduce simple resource_pool by LHT129 · Pull Request #123 · antgroup/vsag

LHT129 · 2024-11-11T03:35:55Z

for visited_list, give an implement of visited_list_pool
we will have some other object like aio_context...
currently hgraph use visitlist from hnswlib, now make it global

inabao · 2024-11-16T07:59:36Z

src/utils/visited_list.h

+    explicit VisitedList(InnerIdType max_size, Allocator* allocator)
+        : max_size_(max_size), allocator_(allocator) {
+        this->list_ = reinterpret_cast<VisitedListType*>(
+            allocator_->Allocate((uint64_t)max_size * sizeof(VisitedListType)));


memory allocation may fail

we have safe allocator

inabao · 2024-11-16T08:01:16Z

src/utils/resource_object_pool.h

+
+public:
+    template <typename... Args>
+    explicit ResourceObjectPool(uint64_t init_size, Args... args) {


Q: Do we need to set a maximum size for the pool to prevent creating too many resources in high concurrency scenarios?

there are to strategy to manage the size, fixed or flexible, currently is flexible. maybe add fixed soon, if necessary

src/utils/resource_object_pool.h

jiaweizone · 2024-11-20T16:22:22Z

src/utils/resource_object_pool.h

+    }
+
+    std::shared_ptr<T>
+    GetOne() {


Here is a Take / Return semantics ?

jiaweizone · 2024-11-20T16:22:35Z

src/utils/resource_object_pool.h

+    }
+
+    void
+    ReleaseOne(std::shared_ptr<T>& obj) {


jiaweizone · 2024-11-20T16:24:25Z

src/utils/resource_object_pool.h

+    }
+
+    std::vector<std::shared_ptr<T>> pool_{};
+    size_t pool_size_{0};


pool_size_ is not necessary, can replace with pool_.size() ?

sometimes may not equal

Can you tell me more about it ?
for thread safe need use std::atomic<size_t>

use atomic instead

src/utils/visited_list.h

src/utils/resource_object.h

src/utils/resource_object_pool.h

src/utils/visited_list.h

src/utils/visited_list_test.cpp

wxyucs

lgtm

inabao · 2025-01-17T07:04:08Z

src/utils/resource_object_pool.h

+        }
+    }
+
+    std::vector<std::shared_ptr<T>> pool_{};


jiaweizone · 2025-01-18T14:51:36Z

src/utils/resource_object_pool.h

+    TakeOne() {
+        std::lock_guard<std::mutex> lock(mutex_);
+        if (pool_.empty()) {
+            return this->constructor_();


minor: here can release the lock mutex_ and then construct the object

jiaweizone · 2025-01-18T15:02:35Z

src/utils/resource_object_pool.h

+    }
+
+    std::vector<std::shared_ptr<T>> pool_{};
+    size_t pool_size_{0};


Can you tell me more about it ?
for thread safe need use std::atomic<size_t>

jiaweizone · 2025-01-18T15:09:57Z

src/utils/resource_object_pool.h

+    }
+
+    void
+    SetConstructor(ConstructFuncType func) {


If there are objects that have already been taken, SetConstructor will have a behavior problem

you are right, but it's hard to reconstruct all objects which have been token, So maybe delete this function, or use the function after all object have been returned?

OK, Add check for all objects returned

inabao

LGTM

jiaweizone · 2025-01-19T11:35:20Z

src/utils/resource_object_pool.h

+    }
+
+    void
+    SetConstructor(ConstructFuncType func) {


OK, Add check for all objects returned

- for visited_list, give an implement of visited_list_pool - we will have some other object like aio_context... - currently hgraph use visitlist from hnswlib, now make it global Signed-off-by: LHT129 <tianlan.lht@antgroup.com>

LHT129 requested review from ShawnShawnYou, inabao and wxyucs November 11, 2024 03:35

LHT129 self-assigned this Nov 11, 2024

pull-request-size bot added the size/L label Nov 11, 2024

LHT129 added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) and removed size/L labels Nov 11, 2024

LHT129 force-pushed the visit_table branch from a855909 to d2993eb Compare November 12, 2024 06:50

pull-request-size bot added the size/L label Nov 12, 2024

LHT129 marked this pull request as ready for review November 12, 2024 08:23

LHT129 requested a review from jiaweizone as a code owner November 12, 2024 08:23

LHT129 force-pushed the visit_table branch from d2993eb to f3589c3 Compare November 12, 2024 08:27

LHT129 changed the title ~~[WIP]introduce simple resource_pool~~ introduce simple resource_pool Nov 13, 2024

LHT129 mentioned this pull request Nov 13, 2024

add hgraph test & fix #125

Closed

LHT129 force-pushed the visit_table branch from f3589c3 to aec206f Compare November 14, 2024 09:01

inabao reviewed Nov 16, 2024

View reviewed changes

LHT129 force-pushed the visit_table branch 3 times, most recently from 18ce304 to b47a6c4 Compare November 20, 2024 07:23

jiaweizone reviewed Nov 20, 2024

View reviewed changes

LHT129 force-pushed the visit_table branch 3 times, most recently from d1fcb50 to 819012a Compare November 27, 2024 09:07

LHT129 force-pushed the visit_table branch 4 times, most recently from 518e82c to 80b1462 Compare December 5, 2024 05:02

LHT129 force-pushed the visit_table branch 3 times, most recently from b11eea9 to dbcc027 Compare December 9, 2024 07:30

LHT129 force-pushed the visit_table branch from ceee664 to 1be6db2 Compare January 16, 2025 03:47

wxyucs reviewed Jan 16, 2025

View reviewed changes

LHT129 force-pushed the visit_table branch 2 times, most recently from 535630d to 9fd743c Compare January 17, 2025 06:59

wxyucs approved these changes Jan 17, 2025

View reviewed changes

inabao reviewed Jan 17, 2025

View reviewed changes

LHT129 force-pushed the visit_table branch 2 times, most recently from 843ea97 to 1ea9076 Compare January 18, 2025 06:36

jiaweizone reviewed Jan 18, 2025

View reviewed changes

LHT129 force-pushed the visit_table branch 2 times, most recently from 23e18ce to a273aaa Compare January 19, 2025 02:41

inabao approved these changes Jan 19, 2025

View reviewed changes

jiaweizone approved these changes Jan 19, 2025

View reviewed changes

introduce simple resource_pool

d594b2c

- for visited_list, give an implement of visited_list_pool - we will have some other object like aio_context... - currently hgraph use visitlist from hnswlib, now make it global Signed-off-by: LHT129 <tianlan.lht@antgroup.com>

LHT129 force-pushed the visit_table branch from a273aaa to d594b2c Compare January 20, 2025 06:05

LHT129 merged commit cefc6b2 into antgroup:main Jan 21, 2025

LHT129 deleted the visit_table branch January 21, 2025 03:20

This was referenced Aug 21, 2025

feat(HGraph): add multi-threaded searcher to parallelize single query execution #1071

Merged

support mrng in hgraph #1076

Closed

sourcery-ai bot mentioned this pull request Sep 1, 2025

feat(Hgraph): support tunning alpha in MRNG #1104

Merged

sourcery-ai bot mentioned this pull request Sep 10, 2025

feat(SINDI): support get memory usage #1141

Merged

This was referenced Oct 17, 2025

feat(io): introduce io_array to manager multi buckets'IO #1246

Merged

fix(sindi): fix parameter checkCompatibility in deserialize #1266

Merged

feat(ivf): add ivf sampling rate function #1273

Closed

This was referenced Nov 5, 2025

feat(index): Support get detail data with info from index #1309

Merged

refactor(safe_call): add exception handling for bad_alloc #1315

Merged

This was referenced Nov 14, 2025

feat(HGraph): support use tau-mng #1338

Open

feat(sparse): support get raw vector #1347

Merged

Conversation

LHT129 commented Nov 11, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wxyucs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

inabao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants