fix: handle None by_alias in model_dump for FastAPI contexts#1165
Open
thecaptain789 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: handle None by_alias in model_dump for FastAPI contexts#1165thecaptain789 wants to merge 1 commit intoanthropics:mainfrom
thecaptain789 wants to merge 1 commit intoanthropics:mainfrom
Conversation
When calling model_dump with by_alias=None (the default), the pydantic-core serializer in certain contexts (like FastAPI) can fail with 'NoneType cannot be converted to PyBool'. This matches the pattern already used in _models.py where by_alias is explicitly converted: by_alias if by_alias is not None else False Fixes anthropics#1160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
model_dumpwithby_alias=None(the default), the pydantic-core serializer in certain async contexts (like FastAPI) can fail with'NoneType' cannot be converted to 'PyBool'.This applies the same pattern already used in
_models.pywhereby_aliasis explicitly converted:Fixes #1160