Extract descriptor types into buffa-descriptor crate#8
Merged
Conversation
rpb-ant
previously approved these changes
Mar 24, 2026
Moves the generated FileDescriptorProto/DescriptorProto types and vendored descriptor.proto sources from buffa-codegen into a new buffa-descriptor crate that depends only on buffa. This makes the descriptor types available without pulling in quote/syn/prettyplease, laying the foundation for runtime reflection. buffa-codegen re-exports buffa_descriptor::generated so all existing crate::generated:: paths resolve unchanged. gen_descriptor_types now takes an explicit output directory argument, eliminating the previous cwd-sensitivity.
iainmcgin
force-pushed
the
buffa-descriptor-crate
branch
from
93b88c2 to
e1e0949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the generated FileDescriptorProto/DescriptorProto types and
vendored descriptor.proto sources from buffa-codegen into a new
buffa-descriptor crate that depends only on buffa. This makes the
descriptor types available without pulling in quote/syn/prettyplease,
laying the foundation for runtime reflection.
buffa-codegen re-exports buffa_descriptor::generated so all existing
crate::generated:: paths resolve unchanged. gen_descriptor_types now
takes an explicit output directory argument, eliminating the previous
cwd-sensitivity.