fix: Add parseInt validation and remove unused environment variable#24111
Open
hobostay wants to merge 1 commit intoanthropics:mainfrom
Open
fix: Add parseInt validation and remove unused environment variable#24111hobostay wants to merge 1 commit intoanthropics:mainfrom
hobostay wants to merge 1 commit intoanthropics:mainfrom
Conversation
This commit includes two bug fixes: 1. Add NaN validation for parseInt operations in backfill-duplicate-comments.ts - Previously, invalid environment variable values would silently become NaN - Now validates that parsed numbers are valid and within reasonable ranges - Throws descriptive error messages for invalid inputs 2. Remove unused STATSIG_API_KEY from auto-close-duplicates.yml workflow - The environment variable was set but never used by the script - Removes confusion about unused configuration These changes improve script reliability and make errors easier to diagnose. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two bug fixes for the scripts:
Add NaN validation for parseInt operations in
backfill-duplicate-comments.tsMAX_ISSUE_NUMBER="invalid") would silently becomeNaN, causing unexpected script behaviorRemove unused
STATSIG_API_KEYfromauto-close-duplicates.ymlworkflowauto-close-duplicates.tsscriptChanges
scripts/backfill-duplicate-comments.tsparseInt()operations to ensure values are notNaNMIN_ISSUE_NUMBERis at least 1MAX_ISSUE_NUMBERis greater thanMIN_ISSUE_NUMBER.github/workflows/auto-close-duplicates.ymlSTATSIG_API_KEYenvironment variable (unused)Test plan
MAX_ISSUE_NUMBERorMIN_ISSUE_NUMBERvaluesMIN_ISSUE_NUMBER >= 1MAX_ISSUE_NUMBER > MIN_ISSUE_NUMBERExample Error Messages
🤖 Generated with Claude Code