fix: Python 3.8 compatibility in hookify config_loader#24266
Open
Sanix-Darker wants to merge 1 commit intoanthropics:mainfrom
Open
fix: Python 3.8 compatibility in hookify config_loader#24266Sanix-Darker wants to merge 1 commit intoanthropics:mainfrom
Sanix-Darker wants to merge 1 commit intoanthropics:mainfrom
Conversation
The extract_frontmatter function in core/config_loader.py uses tuple[Dict[str, Any], str] (lowercase tuple) as a return type annotation. This PEP 585 syntax is only supported in Python 3.9+. On systems running Python 3.8, importing the module raises TypeError: 'type' object is not subscriptable, which crashes every hook execution, those PreToolUse, PostToolUse, and Stop all fail on every tool call, spamming errors throughout the session. The fix just adds Tuple to the typing imports and replaces the lowercase tuple annotation with Tuple, restoring compatibility with Python 3.8+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
The extract_frontmatter function in core/config_loader.py uses tuple[Dict[str, Any], str] (lowercase tuple) as a return type annotation. This PEP 585 syntax is only supported in Python 3.9+. On systems running Python 3.8, importing the module raises TypeError: 'type' object is not subscriptable, which crashes every hook execution, those PreToolUse, PostToolUse, and Stop all fail on every tool call, spamming errors throughout the session. The fix just adds Tuple to the typing imports and replaces the lowercase tuple annotation with Tuple, restoring compatibility with Python 3.8+.