Fix exit codes for duplicate automation scripts#25309
Open
Atman36 wants to merge 1 commit intoanthropics:mainfrom
Open
Fix exit codes for duplicate automation scripts#25309Atman36 wants to merge 1 commit intoanthropics:mainfrom
Atman36 wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The duplicate automation scripts currently exit with code
0even when fatal errors occur (e.g., missingGITHUB_TOKEN). This masks failures in CI/CD pipelines and violates the fail-fast principle.Solution
Updated top-level
.catch()handlers in both scripts to setprocess.exitCode = 1on errors while preserving error logging.Verification
Success path behavior unchanged—only failure signaling is fixed.