feat(security-guidance): add Python security patterns for subprocess, yaml, TLS, and tempfile #25406
+56
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yaml, TLS, and tempfile Add four new security patterns to the security-guidance plugin hook: - subprocess_shell_injection: Warns when shell=True is used with subprocess, which can lead to command injection - yaml_unsafe_load: Warns when yaml.load() is used without SafeLoader, which can execute arbitrary code - tls_verification_disabled: Warns when verify=False disables TLS certificate verification - tempfile_insecure: Warns when tempfile.mktemp() is used, which is vulnerable to race condition attacks These are well-known Python security pitfalls that the existing patterns did not cover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds four Python security patterns to the security-guidance plugin hook that were missing from the existing set:
subprocess_shell_injection— catchesshell=Truein subprocess calls (command injection risk)yaml_unsafe_load— catchesyaml.load()without SafeLoader (arbitrary code execution)tls_verification_disabled— catchesverify=Falsein HTTP requests (MITM attacks)tempfile_insecure— catchestempfile.mktemp()(race condition / symlink attacks)The existing patterns cover eval/exec/os.system/pickle but miss these four, which OWASP and Python security guides consistently flag. Each pattern includes a warning message explaining what is unsafe and what to use instead.
Tested all patterns match correctly without affecting existing ones.