Add linenoiseResize#252
Open
adsr wants to merge 1 commit intoantirez:masterfrom
Open
Conversation
Currently if the terminal is resized in the middle of a line edit, then `cols` goes stale and the output is garbled. In regular mode, the only way to detect this would be to query terminal size after every input (bad), or to install a signal handler for `SIGWINCH` (bigger change). In async mode, the caller can install their own signal handler, but has no way to tell the library to refetch terminal size. This function allows the caller to do that. To demo this, add `--async-resize` flag to the example program. Also replace tabs in example.c with spaces. Previously it was mixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the terminal is resized in the middle of a line edit, then
colsgoes stale and the output is garbled.In regular mode, the only way to detect this would be to query terminal size after every input (bad), or to install a signal handler for
SIGWINCH(bigger change).In async mode, the caller can install their own signal handler, but has no way to tell the library to refetch terminal size. This function allows the caller to do that.
To demo this, add
--async-resizeflag to the example program.Also replace tabs in example.c with spaces. Previously it was mixed.