refactor(slider): update UI & add brush interaction.#290
Merged
pepper-nice merged 2 commits intomasterfrom Feb 15, 2023
Merged
Conversation
zhangjunjie-loki
force-pushed
the
refactor/slider
branch
from
567bbb9 to
f8f68c0
Compare
Member
|
ci 问题是 |
zhangjunjie-loki
force-pushed
the
refactor/slider
branch
from
f8f68c0 to
63c425a
Compare
zhangjunjie-loki
force-pushed
the
refactor/slider
branch
2 times, most recently
from
d99fab5 to
fbde86b
Compare
zhangjunjie-loki
force-pushed
the
refactor/slider
branch
from
fbde86b to
ae67701
Compare
hustcc
approved these changes
Feb 14, 2023
visiky
reviewed
Feb 15, 2023
| export function getCurrentPoint(e: Event) { | ||
| const event = e.originalEvent as MouseEvent; | ||
| return { | ||
| x: get(event, 'touches.0.pageX', event.pageX), |
Member
There was a problem hiding this comment.
这个方法是在哪里使用的～ event.touches 应该是在 Touch 事件下？PC 端的是在 pointEvent 下？
Contributor
Author
There was a problem hiding this comment.
这个方法本来之前多个地方使用，所以我抽象出来了。但是忘记在slider中替换了，我也下个PR一起改掉！
zhangjunjie-loki
pushed a commit
that referenced
this pull request
May 4, 2023
* feat(slider): add brush interaction * feat(slider): update foreground ui
hustcc
pushed a commit
that referenced
this pull request
Oct 7, 2023
* fix(legend-item): update attributes * fix: cr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
设计稿：https://done.alibaba-inc.com/share/file/UnfMwBa6RLfSgFTQ?pageId=FB673644-9B49-4E46-A95F-CBB4C8DBD077&aid=9538D5EF-0A95-47FC-800B-FA116006ABA8&m=SPECS
功能点
Brush Interaction
UI更新
文字超长换行检测