Tony/257 notification

[tonypioneer]

Pull Request Details

What issue does this PR address

• Added a series of methods related to notification.
• Added a notification icon on the AppBar.
• Added a notification centre.
• Fixed some minor issues in POD initialisation.

Associated Issue

• This PR relates to issue APPBAR: Add notification when resource shared to user solidui#257

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Build and run the app.

Please modify the pointed branches of SolidUI and SolidPod in pubspec.yaml to dev before merge.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue APPBAR: Add notification when resource shared to user solidui#257
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[jesscmoore]

Hi Tony, I tested this branch. See comment in the matching solidui PR:
anusii/solidui#266 (review)

[jesscmoore]

Hi Tony.
Worked well in Demopod.
But when the recipient doesn't have an account on the app which sent the notification, it returns a 403 when trying to send the notification. This happened when charliesolidtester used Demopod to try to send a notification to karen-reep, when karen-reep hadn't previously used the Demopod app.
After karen-reep had setup demopod the notification test sending a notification from charlie to karen in demopod worked just fine.

Could you add a test to check the webid has an account?

It could be similar to that done in the granting permissions workflow. That would catch this user error, and provide a helpful response.

[tonypioneer]

Hi Tony.
Worked well in Demopod.
But when the recipient doesn't have an account on the app which sent the notification, it returns a 403 when trying to send the notification. This happened when charliesolidtester used Demopod to try to send a notification to karen-reep, when karen-reep hadn't previously used the Demopod app.
After karen-reep had setup demopod the notification test sending a notification from charlie to karen in demopod worked just fine.

Could you add a test to check the webid has an account?

It could be similar to that done in the granting permissions workflow. That would catch this user error, and provide a helpful response.

Hi @jesscmoore, thank you very much for the feedback. I'll fix this issue.

[jesscmoore]

Hi @tonypioneer, a related scenario, is when the recipient has a valid webid, and is a user of the same app, but doesn't not yet have a notification folder, because they have not used the app since that folder was added to the setup. This also returns a 403 error. Eg. below karen-reep using notepod to share a file to charliesolidtester and jesscmoore. Where neither of the recipients has run notepod with the tony/257_notification branch.

Maybe the feedback message should be, that the recipient needs to first login and update their app setup in their Pod, before you can send notifications.

flutter: [GrantPermissionForm] Failed to send notification to https://pods.solidcommunity.au/charliesolidtester/profile/card#me: Exception: Failed to create resource!
flutter: URL: https://pods.solidcommunity.au/charliesolidtester/notepod/notification/1775467269681.json
flutter: ERROR: {"name":"ForbiddenHttpError","message":"","statusCode":403,"errorCode":"H403","details":{}}
flutter: [GrantPermissionForm] Failed to send notification to https://pods.solidcommunity.au/jesscmoore/profile/card#me: Exception: Failed to create resource!
flutter: URL: https://pods.solidcommunity.au/jesscmoore/notepod/notification/1775467352831.json
flutter: ERROR: {"name":"ForbiddenHttpError","message":"","statusCode":403,"errorCode":"H403","details":{}}