Austemp

[lbesnard]

No description provided.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.89%. Comparing base (6708b62) to head (9ef1c42).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
..._optimised/bin/generic_cloud_optimised_creation.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   64.89%   64.89%           
=======================================
  Files          30       30           
  Lines        5253     5253           
=======================================
  Hits         3409     3409           
  Misses       1844     1844           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lbesnard]

@copilot can you review this PR?

[Copilot]

@lbesnard I've opened a new pull request, #251, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

This PR introduces configuration and launch scaffolding for the AusTemp SST anomaly 8-day dataset (cloud-optimised Zarr), along with a sample NetCDF, and includes a small update to shared ingestion logic and an unrelated cluster-thread tweak for a GHRSST dataset.

Changes:

• Add new dataset config for satellite_austemp_sst_8day (run settings, schema, AWS Open Data registry metadata).
• Add AusTemp sample NetCDF (satellite_austemp_sst_8day.nc) and a corresponding launcher script.
• Adjust collect_files() filtering behavior and reduce worker nthreads for satellite_ghrsst_l3c_4hour_himawari8.

Reviewed changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
aodn_cloud_optimised/config/dataset/satellite_ghrsst_l3c_4hour_himawari8.json	Updates worker thread count in cluster worker options.
aodn_cloud_optimised/config/dataset/satellite_austemp_sst_8day.nc	Adds a sample NetCDF input for AusTemp.
aodn_cloud_optimised/config/dataset/satellite_austemp_sst_8day.json	Adds full dataset + schema + AWS Open Data registry config for AusTemp 8-day SST anomalies.
aodn_cloud_optimised/bin/satellite_austemp_sst_8day.py	Adds a launcher entrypoint to run the generic creation script with the AusTemp config.
aodn_cloud_optimised/bin/generic_cloud_optimised_creation.py	Changes how file regex filtering is applied/validated in collect_files().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The AWS Open Data registry metadata still contains the placeholder tag value "FILL UP MANUALLY - CHECK DOCUMENTATION". This looks like unfinished metadata and will leak into the published registry entry; please replace it with real dataset tags (or an empty list if tags are intentionally omitted).

Suggested change

	"Tags": [
	"FILL UP MANUALLY - CHECK DOCUMENTATION"
	],
	"Tags": [],

[Copilot]

Pull request overview

Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.

[Copilot]

aws_opendata_registry.Tags contains the placeholder string "FILL UP MANUALLY - CHECK DOCUMENTATION", which is explicitly rejected by DatasetConfig.validate_no_manual_fill_placeholders() and will fail config validation at runtime. Replace this placeholder with real tags (or remove the entry) so the dataset can be built.

Suggested change

	"FILL UP MANUALLY - CHECK DOCUMENTATION"
	"IMOS",
	"AusTemp",
	"sea surface temperature",
	"SST",
	"satellite",
	"oceanography",
	"Australia",
	"marine heatwaves",
	"climate"

[Copilot]

Pull request overview

Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.

[Copilot]

The nthreads parameter for satellite_ghrsst_l3c_4hour_himawari8 is being changed from 4 to 1. While this aligns with the pattern used by most other satellite datasets in the repository (which use nthreads: 1), this change appears unrelated to adding AusTemp support and is not mentioned in the PR title. If this is an intentional performance tuning change, it should either be documented in the PR description or moved to a separate PR to keep changes focused and easier to review.