Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across configuration handling, timestamp processing, dependency management, and testing. The changes enhance robustness for timestamp conversion, improve configuration validation (especially for CSV ingestion), update the dependency list, and add new tests and documentation. Below are the most important changes grouped by theme:
Configuration and Validation Improvements:
csv_configsection to dataset configuration files (e.g.,animal_acoustic_tracking_delayed_qc.json) with validation ensuring only one ofpandas_read_csv_configorpolars_read_csv_configis provided, and improved documentation to clarify mutually exclusive options and validation rules. [1] [2] [3]year_rangeandcoiled_cluster_optionsfields to acceptnullvalues as well as their original types, improving flexibility inschema_validation_parquet.json. [1] [2]spatial_extentblock from themooring_temperature_logger_delayed_qc.jsondataset config, likely to avoid redundancy or potential conflicts.force_previous_parquet_deletiontotrueinaggregated_seabird_nonqc.json, ensuring previous Parquet files are deleted before processing.Timestamp Handling and Code Robustness:
GenericParquetHandler.pyto use nanosecond resolution with.as_unit("ns"), ensuring consistent behavior across differenth5pyversions and platforms. [1] [2]Dependency and Compatibility Updates:
pydantic>=2.12.5to project dependencies and updated the Python version constraint to<3.15inpyproject.toml, improving compatibility and validation capabilities. [1] [2]pyproject.toml. [1] [2] [3]Testing and Platform Support:
conftest.pyto setDYLD_LIBRARY_PATHon macOS, ensuring tests can find Homebrew-installed libraries during collection.test_orchestrate_generate.pyfor thegenerateandoptimisefunctions, improving test coverage for core orchestration logic.Internal Code Quality:
config.pyby usingas_filecontext manager for loading configuration files, increasing reliability and compatibility with different importlib resource backends. [1] [2]