Skip to content

Automate check for core-> providers deps #11435

Open

Description

@potiuk

We should automate a check for dependencies between the core and providers. This should be CI-automated check that will prevent people from accidentally creating a dependency on any of the providers.

Linked issue #12247

Activity

  1. self-assigned this
    on Oct 11, 2020
  2. added this to the Airflow 2.0.0 milestone on Oct 11, 2020
  3. changed the title [-]Autoamate check for core-> providers deps[/-] [+]Automate check for core-> providers deps[/+] on Oct 12, 2020
  4. removed their assignment
    on Nov 10, 2020
  5. turbaszek commented on Nov 10, 2020

    @turbaszek
    Member

    There's a dependency on kubernetes in example dags:

    from kubernetes.client import models as k8s

    which is not required dependency for Airflow. If users don't have installed kubernetes package then they will face errors when using example dags as mentioned in #12247.

  6. self-assigned this
    on Nov 18, 2020
  7. added
    kind:taskA task that needs to be completed as part of a larger issue
    on Feb 9, 2021
  8. eladkal commented on Aug 4, 2024

    @eladkal
    Contributor

    I believe this one is completed as we are checking against min provider versions

  9. potiuk commented on Aug 4, 2024

    @potiuk
    MemberAuthor

    Not really. This one is to make sure that in "core" code and tests providers are not used. This is not yet entirely true because even if FAB is in a separate provider. This should be fixed by separating FAB out (cc: @jedcunningham) in AIP-79, because some tests and some core files are referring to FAB provider.

    I think we also have some K8S and celery provider references in core tests + some of the tests in core "always" are actually expecting providers to be installed and will fail if they are not.

    This one is basically a prerequisite if we would want to move providers out in sources (we don't for now) - so no high priority, it's more something that eventually should happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions