Skip to content

GoogleDisplayVideo360Hook.download_media does not pass the resourceName correctly #14077

Closed

Description

@sarahamilton

Apache Airflow version: 1.10.12

Environment: Google Cloud Composer 1.13.3

  • Cloud provider or hardware configuration:
  • Google Cloud Composer

What happened:
The GoogleDisplayVideo360Hook.download_media hook tries to download media using the "resource_name" argument. However, per the API spec it should pass "resourceName" Thus, it breaks every time and can never download media.

Error: ERROR - Got an unexpected keyword argument "resource_name"

What you expected to happen: The hook should pass in the correct resourceName and then download the media file.

How to reproduce it: Run any workflow that tries to download any DV360 media.

Anything else we need to know: I have written a patch that fixes the issue and will submit it shortly.

Activity

  1. mishc9 commented on Dec 27, 2021

    @mishc9
    Contributor

    I've opened new PR based on this closed pull request that could resolve this issue. Fixed tests that failed in original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions