You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
SparkKubernetesOperator to support arguments #16728
I think this should already allow .json type file to be uploaded from the UI? I would appreciate it if you could provide me with any pointers on how to start this issue. 😅
If you meant template_ext contains .json, that only affects the listed templated_fields. I think OP wants to be able to pass a path from the “Trigger DAG” page’s param field, which is a completely different thing.
The scope of this change is mainly to make sure that you can pass the CRD .yaml file (possibly in json form) through a Param of the kind that will be easy to enter/ validate via UI and document it.
I do not think there is a lot (maybe no) code is to be written on that one - mostly to see if the current Param .json type will nicely fit there and provide an example of defining such param in the task and testing it.
Most likely the output of the task will be to add an example dag and UI screenshot to the documentation describing how to do it.
UPDATE: possibly it will need "application_file_content" optional field to be added (or simillar)
Activity
uranusjr commentedon Jun 30, 2021
Would you be interested in submitting a PR? It would be nice if you could use the issue template in the future as well.
goodhamgupta commentedon Aug 3, 2021
Incase this has not yet been picked up, I would like to work on this issue 😄
potiuk commentedon Aug 3, 2021
Assigned you @goodhamgupta !
goodhamgupta commentedon Aug 6, 2021
Hi @potiuk,
I think I don't understand the issue well enough. I see that for the SparkKubernetesOperator, the following code segment:
I think this should already allow .json type file to be uploaded from the UI? I would appreciate it if you could provide me with any pointers on how to start this issue. 😅
Thanks!
goodhamgupta commentedon Sep 13, 2021
@potiuk, @uranusjr Sorry for the noise, but I would appreciate any hints you might be able to provide 😄
uranusjr commentedon Sep 13, 2021
If you meant
template_extcontains.json, that only affects the listedtemplated_fields. I think OP wants to be able to pass a path from the “Trigger DAG” page’s param field, which is a completely different thing.eladkal commentedon Dec 19, 2021
@goodhamgupta are you still working on this issue?
goodhamgupta commentedon Dec 19, 2021
@eladkal Unfortunately I wasn't able to work on this issue for now.
potiuk commentedon Sep 9, 2023
Answering earlier question (which I missed):
The scope of this change is mainly to make sure that you can pass the CRD .yaml file (possibly in json form) through a Param of the kind that will be easy to enter/ validate via UI and document it.
I do not think there is a lot (maybe no) code is to be written on that one - mostly to see if the current Param .json type will nicely fit there and provide an example of defining such param in the task and testing it.
Most likely the output of the task will be to add an example dag and UI screenshot to the documentation describing how to do it.
UPDATE: possibly it will need "application_file_content" optional field to be added (or simillar)