Release 2.5.1 of Amazon Provider #20457

Activity

1. kaxil

   added

   kind:bugThis is a clearly a bugThis is a clearly a bug

   area:core

   area:providers

   provider:amazonAWS/Amazon - related issuesAWS/Amazon - related issues

   and removed

   area:core

   on Dec 21, 2021
2. kaxil commented on Dec 21, 2021

   

   kaxil

   on Dec 21, 2021

   MemberAuthor

   More actions

   cc @potiuk
3. potiuk commented on Dec 21, 2021

   

   potiuk

   on Dec 21, 2021

   Last edited by potiuk

   Member

   More actions

   What kind of breaking changes they are @uranusjr ?
   They are not immediately visible. Can we make it backwards-compatible instead?
   I would not introduce backwards incompatibility unless we really have a good reason.
4. uranusjr commented on Dec 22, 2021

   

   uranusjr

   on Dec 22, 2021

   Member

   More actions

   On the surface level, the AwsBaseHook.expand_role() now calls _get_credentials() with no arguments, which is not supported on older versions, and thus if someone subclasses the hook to reimplement _get_credentials(), the code would break after upgrade.

   More deeply though, expand_role() used to depend on boto’s get_client_type() with a dynamic client type, which is deprecated in newer Boto versions. Tt now uses _get_credentials() instead to avoid the deprecation. But expand_role() does not tak a region argument and therefore cannot pass one to _get_credentials(). If we keep compatibility on _get_credentials(), we’d break compatibility on expand_role() instead.
5. potiuk commented on Dec 22, 2021

   

   potiuk

   on Dec 22, 2021

   Last edited by potiuk

   Member

   More actions

   More deeply though, expand_role() used to depend on boto’s get_client_type() with a dynamic client type, which is deprecated in newer Boto versions. Tt now uses _get_credentials() instead to avoid the deprecation. But expand_role() does not tak a region argument and therefore cannot pass one to _get_credentials(). If we keep compatibility on _get_credentials(), we’d break compatibility on expand_role() instead.

   Can't we pass None explicitly as region from the expand_role() and leave the region argument Optional but without default ?
6. uranusjr commented on Dec 22, 2021

   

   uranusjr

   on Dec 22, 2021

   Member

   More actions

   Hmm, I think so. And maybe expand_role() should gain an optional region_name argument as well (defaulting to None and never explicitly used in the provider until 3.0).
7. potiuk commented on Dec 22, 2021

   

   potiuk

   on Dec 22, 2021

   Member

   More actions

   Yeah. Seems to small af a thing to make whole provider backwards incompatible.
8. potiuk

   changed the title [-]Release 3.0.0 of Amazon Provider[/-] [+]Release 2.5.1 of Amazon Provider[/+] on Dec 22, 2021
9. potiuk

   closed this as completedin #20463on Dec 22, 2021
10. potiuk

    added a commit that references this issue on Dec 22, 2021

    Fix backwards compatibility issue in AWS provider's _get_credentials (#…

    ...

    This issue will close once commit 2ab2ae8 is merged into the 'main' branch.

    2ab2ae8