You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bbovenzi I would like to pick this up in case you are not working on this. I have a rough working version of this and can also work on queue, run endpoints. I would like to confirm below things.
The linked API has confirmed parameter which will return a str value of task_instances on false. Do we need to support this parameter in query parameter? If so do we need to return str value of task_instances or do we need to return like the endpoint where task_instances for a dag_run or returned.
Since we have dag_id and dag_run_id in the URL do we need this as a post endpoint since confirmed is also a query parameter and we are not posting additional data whereas the linked API uses post since /dagrun_clear has no details of dag_id and dag_run_id. It makes sense for post if the API will be expanded in future to support more customisation.
Activity
tirkarthi commentedon May 3, 2022
@bbovenzi I would like to pick this up in case you are not working on this. I have a rough working version of this and can also work on queue, run endpoints. I would like to confirm below things.
confirmedparameter which will return astrvalue of task_instances on false. Do we need to support this parameter in query parameter? If so do we need to returnstrvalue of task_instances or do we need to return like the endpoint where task_instances for a dag_run or returned.dag_idanddag_run_idin the URL do we need this as a post endpoint since confirmed is also a query parameter and we are not posting additional data whereas the linked API uses post since/dagrun_clearhas no details ofdag_idanddag_run_id. It makes sense for post if the API will be expanded in future to support more customisation.bbovenzi commentedon May 3, 2022
confirmed, we senddry_run. The return should be json instead of a string.