Skip to content

Don’t prompt for 'breeze build-image' #23867

Closed

Description

@uranusjr

Body

Currently, running the (new) breeze build-image brings up two prompts if any of the meta files are outdated:

$ breeze build-image
Good version of Docker: 20.10.14.
Good version of docker-compose: 2.5.1
The following important files are modified in ./airflow since last time image was built:

 * setup.py
 * Dockerfile.ci
 * scripts/docker/common.sh
 * scripts/docker/install_additional_dependencies.sh
 * scripts/docker/install_airflow.sh
 * scripts/docker/install_airflow_dependencies_from_branch_tip.sh
 * scripts/docker/install_from_docker_context_files.sh

Likely CI image needs rebuild

Do you want to build the image (this works best when you have good connection and can take usually from 20 seconds to few minutes depending how old your image is)?
Press y/N/q. Auto-select n in 10 seconds (add `--answer n` to avoid delay next time): y

This might take a lot of time (more than 10 minutes) even if you havea good network connection. We think you should attempt to rebase first.

But if you really, really want - you can attempt it. Are you really sure?
Press y/N/q. Auto-select n in 10 seconds (add `--answer n` to avoid delay next time): y

While the prompts are shown in good nature, they don’t really make sense for build-image since the user already gave an explicit answer by running build-image. They should be suppressed.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.

Activity

  1. potiuk commented on May 23, 2022

    @potiuk
    Member

    Oh absolutely :). It's been like that in the old breeze :)

  2. added a commit that references this issue on May 24, 2022
    477ea36
  3. added a commit that references this issue on May 24, 2022
    90940b5
  4. added a commit that references this issue on Jun 2, 2022
    b10afd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions