grid_data api keep refreshing when backfill DAG runs #24844

Activity

1. yingxuanwangxuan

   added

   area:core

   kind:bugThis is a clearly a bugThis is a clearly a bug

   on Jul 5, 2022
2. boring-cyborg commented on Jul 5, 2022

   

   boring-cyborgBot

   on Jul 5, 2022

   More actions

   Thanks for opening your first issue here! Be sure to follow the issue template!
3. bhavaniravi commented on Jul 5, 2022

   

   bhavaniravi

   on Jul 5, 2022

   Contributor

   More actions

   @yingxuanwangxuan can you add more info

   1. When do you see this error?
   2. What should happen instead?
   3. How can we reproduce this?

   Currently, it looks like the grid view is updating because Auto-refresh is enabled
4. bbovenzi

   added

   area:UIRelated to UI/UX. For Frontend Developers.Related to UI/UX. For Frontend Developers.

   and removed

   area:core

   on Jul 5, 2022
5. bbovenzi commented on Jul 5, 2022

   

   bbovenzi

   on Jul 5, 2022

   Last edited by bbovenzi

   Contributor

   More actions

   You can manually click the auto-refresh toggle off to prevent this.
   Otherwise, those backfilled runs are "pending" and will refresh.
6. yingxuanwangxuan commented on Jul 6, 2022

   

   yingxuanwangxuan

   on Jul 6, 2022

   ContributorAuthor

   More actions

   You can manually click the auto-refresh toggle off to prevent this. Otherwise, those backfilled runs are "pending" and will refresh.
   I think this is a problem, can I fix it.
7. yingxuanwangxuan commented on Jul 6, 2022

   

   yingxuanwangxuan

   on Jul 6, 2022

   ContributorAuthor

   More actions

   @yingxuanwangxuan can you add more info

   1. When do you see this error?
   2. What should happen instead?
   3. How can we reproduce this?

   Currently, it looks like the grid view is updating because Auto-refresh is enabled

   step1 I schedule DAG（airflow_log_cleanup).
   step2 I backfill it.
   dags backfill airflow_log_cleanup -s 2022-06-11 -e 2022-06-20 --donot-pickle
   step3
   

   I wish it didn't refresh automatically all the time.
8. bbovenzi commented on Jul 6, 2022

   

   bbovenzi

   on Jul 6, 2022

   Contributor

   More actions

   What solution do you want other than the already existing ability to manually turn off auto-refresh?
9. yingxuanwangxuan commented on Jul 6, 2022

   

   yingxuanwangxuan

   on Jul 6, 2022

   ContributorAuthor

   More actions

   What solution do you want other than the already existing ability to manually turn off auto-refresh?

   in [airflow/www/static/js/grid/api/useGridData.ts] by filter manual and scheduled
   
10. yingxuanwangxuan commented on Jul 7, 2022

    

    yingxuanwangxuan

    on Jul 7, 2022

    ContributorAuthor

    More actions

    What solution do you want other than the already existing ability to manually turn off auto-refresh?

    I'm not sure this is a good solution, can I submit a pr to fix it?
11. bbovenzi commented on Jul 7, 2022

    

    bbovenzi

    on Jul 7, 2022

    Contributor

    More actions

    Yeah, go for it!
12. bbovenzi

    closed this as completedin #25042on Jul 20, 2022
13. cloventt commented on Aug 25, 2022

    

    cloventt

    on Aug 25, 2022

    Contributor

    More actions

    I'm not sure I understand the reason for this change. Why would you not want the page to auto-refresh? Auto-refresh is useful for seeing the state of running tasks, regardless of whether that task was triggered via a backfill, schedule or manually.

    👍React with 👍2Reacted by pyter and Tim Sanders
14. yingxuanwangxuan commented on Aug 25, 2022

    

    yingxuanwangxuan

    on Aug 25, 2022

    Last edited by yingxuanwangxuan

    ContributorAuthor

    More actions

    I'm not sure I understand the reason for this change. Why would you not want the page to auto-refresh? Auto-refresh is useful for seeing the state of running tasks, regardless of whether that task was triggered via a backfill, schedule or manually.

    @cloventt
    I am using AirFlow1.10. When I tried to upgrade to a higher version. I found this feature auto-refresh is useful for seeing the state of running tasks. When I backfill my task, the state of these tasks is pending which keeps refreshing.

    The airflow Grid page maintains backfilled task state by automatically refreshing whether this is the most appropriate way？ Because the backfill command does not re-run completed DAGs within the given period unless we explicitly instruct it to do.
15. Gollum999 commented on Sep 7, 2022

    

    Gollum999

    on Sep 7, 2022

    Contributor

    More actions

    I'm a bit confused by this thread. I have been doing a lot of backfilling recently and I personally find the auto-refresh behavior to be quite useful for monitoring progress. It's still not entirely clear to me what the bug is, but disabling auto-refresh for all backfills seems a bit heavy-handed to me.
16. cloventt commented on Sep 13, 2022

    

    cloventt

    on Sep 13, 2022

    Contributor

    More actions

    I'm in the same camp @Gollum999 , I still can't visualise a situation in which it would be preferred not to automatically refresh the UI when any task or DAG is running/pending, regardless of whether it was started by a backfill.

    👍React with 👍1Reacted by Tim Sanders
17. potiuk commented on Sep 13, 2022

    

    potiuk

    on Sep 13, 2022

    Member

    More actions

    I would kindly suggest any of the people who are commenting here, on a closed task to submit a PR fixing it. I think there are a number of ways this can be handled - so if any of you has an idea, constructive PR proposing a fix (especially that there is a linked PR that disabled it that can be used as starting point) is much better approach than commenting on a closed issue.

    I heartily invite any of you @cloventt @Gollum999 @yingxuanwangxuan to attempt to do it.
18. Gollum999 commented on Sep 15, 2022

    

    Gollum999

    on Sep 15, 2022

    Contributor

    More actions

    @potiuk Well, if it were up to me I would just revert the original PR, but that doesn't seem especially productive. 😄

    I was hoping to get some more details from @yingxuanwangxuan (or perhaps @bbovenzi) to better understand the reason behind this change.

    Would it help to re-open this thread? Or start a new one?
19. bbovenzi commented on Sep 18, 2022

    

    bbovenzi

    on Sep 18, 2022

    Contributor

    More actions

    Looking at this again, maybe we should revert this change. It is possible to turn off auto-refresh when a user doesn't want it. Therefore, the previously functionality is the most flexible for all users. @Gollum999 I'd welcome a PR to change it.
20. yingxuanwangxuan commented on Oct 11, 2022

    

    yingxuanwangxuan

    on Oct 11, 2022 via email

    ContributorAuthor

    More actions

    I am using AirFlow1.10. When I tried to upgrade to a higher version. I found this feature auto-refresh is useful for seeing the state of running tasks. When I backfill my task, the state of these tasks is pending which keeps refreshing. The airflow Grid page maintains backfilled task state by automatically refreshing whether this is the most appropriate way？ Because the backfill command does not re-run completed DAGs within the given period unless we explicitly instruct it to do. | | hefeixuanzi | | ***@***.*** | On 8/25/2022 11:50，David ***@***.***> wrote： I'm not sure I understand the reason for this change. Why would you not want the page to auto-refresh? Auto-refresh is useful for seeing the state of running tasks, regardless of whether that task was triggered via a backfill, schedule or manually. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>