Try number is incorrect #32290

Activity

1. aamster

   added

   area:core

   kind:bugThis is a clearly a bugThis is a clearly a bug

   needs-triagelabel for new issues that we didn't triage yetlabel for new issues that we didn't triage yet

   on Jun 30, 2023
2. pankajastro

   removed

   needs-triagelabel for new issues that we didn't triage yetlabel for new issues that we didn't triage yet

   on Jul 2, 2023
3. Adaverse commented on Jul 3, 2023

   

   Adaverse

   on Jul 3, 2023

   Last edited by Adaverse

   Contributor

   More actions

   I looked into it, the endpoint api/v1/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/{task_id} and it was giving the right result. In the code, it is seems to be attached to the field _try_number

   _try_number = auto_field(data_key="try_number")
   

   but the one we see in the UI is try_number attribute from TaskInstance model which is _try_number + 1 for finished tasks

       @hybrid_property
       def try_number(self):
           """
           Return the try number that this task number will be when it is actually
           run.
   
           If the TaskInstance is currently running, this will match the column in the
           database, in all other cases this will be incremented.
           """
           # This is designed so that task logs end up in the right file.
           if self.state == State.RUNNING:
               return self._try_number
           return self._try_number + 1
   

   So we can, instead of showing try_number we can show _try_number in the UI.

   Will open a PR for this.
4. ephraimbuddy

   assigned

   Adaverse

   on Jul 4, 2023
5. potiuk

   closed this as completedin #32361on Jul 5, 2023