Skip to content

Log appropriate trigger cancel reasons #33877

Closed

Description

@pankajkoti

Description

Continuing the conversation from the topic covered in #31720, we successfully managed the cancellation resulting from trigger timeout within pull request #31757. Within the same pull request, a generic cancellation log was introduced. This log, however, also surfaces during instances where the trigger completes successfully. To address this matter, pull request #33874 is in progress, aiming to eliminate this generalized trigger log. This alteration is prompted by user feedback, revealing that the presence of the general log caused confusion by implying errors even in cases of successful triggers.

In accordance with the deliberations in issue #31720, it is necessary for us to implement a system that facilitates the communication of pertinent causes for diverse trigger cancellation scenarios. And we need to then incorporate logic designed to convey specific cancellation explanations and subsequently record corresponding detailed cancellation logs.

Use case/motivation

No response

Related issues

#31720

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Activity

  1. boring-cyborg commented on Aug 29, 2023

    @boring-cyborg

    Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

  2. removed
    needs-triagelabel for new issues that we didn't triage yet
    on Oct 16, 2023
  3. RNHTTR commented on Nov 27, 2023

    @RNHTTR
    Contributor

    Closed by #33874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions