Repository navigation
AIP-84 Migrate Dag Run related public endpoint to FastAPI #42701
Description
Description
Migrate following endpoint
- List DAG runs - AIP-84 Migrate GET Dag Runs endpoint to FastAPI #43506
- Trigger a new DAG run - AIP-84 Migrate Trigger Dag Run endpoint to FastAPI #43875
- List DAG runs(batch) - AIP-84 Migrate POST list Dag Runs(batch) endpoint to FastAPI #44170
- Get a DAG run - AIP-84 Migrate GET Dag Run endpoint to FastAPI #42725
- Delete a DAG run - AIP-84 Migrate delete Dag Run endpoint to FastAPI #42910
- Modify a DAG run - AIP-84 Migrate Modify Dag Run endpoint to FastAPI #42973
- Clear a DAG run - AIP-84 Migrate Clear Dag Run public endpoint to FastAPI #42975
- Get
datasetasset events for a DAG run -AIP-84 Migrate GET asset event for a Dag Run endpoint to FastAPI #43876AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI #43874 -
Update the DAGRun note - AIP-84 Migrate Modify Dag Run Note endpoint to FastAPI #42974 - update dag run note in PATCH dag_run endpoint - AIP-84 Add ability to update dag run note in PATCH dag_run endpoint #43508
Use case/motivation
Related issues
Relates to: #42370
Are you willing to submit a PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Activity
[-][AIP-84] Migrate Dag Run related public endpoint to FastAPI [/-][+]AIP-84 Migrate Dag Run related public endpoint to FastAPI [/+]bbovenzi commentedon Nov 6, 2024
Important to note. For triggering a dagrun, the api_connexion endpoint is missing a lot of the form fields that @jscheffl added to views.py. I think if its best if we consolidate to a single public trigger dag run endpoint in FastAPI.
jscheffl commentedon Nov 6, 2024
I was always looking at
/api/v1/ui/#/DAG/get_dag_details(airflow/api_connexion/endpoints/dag_endpoint.py:get_dag_details()` which contains a dict of all params definitions. I think this should contain all needed information to generate the form views.Have not checked all default but looking at the fast API I feel like this is the same, have not checked for alle details of complete-ness. But this could be added-in there... I think --> http://localhost:29091/docs#/DAG/get_dag_details (Try it with
example_params_ui_tutorialand take a look toparamsin the response.And for the triggering after the form is rendered... I assume a "plain dict" just need to be passed as
confto the trigger DAG run endpoint like today... so in my view the public API should be sufficient.FYI @shubhamraj-git
rawwar commentedon Nov 27, 2024
Thank you so much for your help @pierrejeambrun , @bugraoz93 , @omkar-foss . I learned a lot while contributing to this endpoint.
pierrejeambrun commentedon Nov 27, 2024
Thanks @rawwar for you contributions :)