AIP-84 Migrate Config related public endpoint to FastAPI #42745
Description
Description
Migrate the following endpoint:
- Get Current configuration
- Get a option from configuration
Use case/motivation
Related issues
Relates to: #42370
Are you willing to submit a PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Activity
rawwar commentedon Oct 4, 2024
For Get config,
airflow/airflow/api_connexion/endpoints/config_endpoint.py
Line 84 in b0a18d9
Docs does not mention about 406(HTTPStatus.NOT_ACCEPTABLE) status code. Should we include 406 as well?
airflow/airflow/api_connexion/endpoints/config_endpoint.py
Line 71 in b0a18d9
Another question about the response. Do we only return JSON or also consider text response?
pierrejeambrun commentedon Oct 9, 2024
I think we should support all the
content-typethat the legacy endpoint was supporting, so yes I would say multiple of them (JSON, text etc.) we need to actually check what should be supported.We can add 406 that's not a problem. Though I would tend to return a general 422 ValidationError, like the client response is wrong because the mimetype suggested is not supported. I'm not really for having a multitute of response code from the API, the 406 one is really singular I would say.
We can even add
breakingto the PR and document that the response code error changed. So it will be documented in airflow 3 breaking changes.jason810496 commentedon Nov 4, 2024
Hi @rawwar, I can take this on. Could you please assign the issue to me? Thanks!