E2E: Improve Playwright test patterns in pools.spec.ts

[choo121600]

Description

Improve Playwright test patterns in pools.spec.ts and related page object to align with Playwright Best Practices.

This PR focuses on improving test patterns only.
It does not change test coverage or behavior.

Checklist

• page.waitForFunction() with DOM queries → locator-based waiting
• page.waitForTimeout() → state-based waiting
• waitForLoadState("networkidle") → wait for specific UI state
• Manual assertions → web-first assertions
• page.evaluate() for DOM manipulation → observe UI state instead
• CSS :has-text() → user-facing locators

Scope

This issue covers improvements in:

• specs/pools.spec.ts
• pages/PoolsPage.ts

Use case/motivation

No response

Related issues

Part of #63036

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[passionworkeer]

A clean way to tackle this is to push the waiting logic into PoolsPage and expose only user-facing locators/actions from the spec.

Suggested refactor:

• replace waitForFunction / waitForTimeout with �wait expect(locator).toBeVisible() or oHaveText() on the table / empty state / toast that actually gates the next step
• avoid
  etworkidle; wait for the specific pool row count or a known row name instead
• if the spec currently uses :has-text() or DOM queries, promote those into stable getByRole(...) / getByText(...) locators in the page object so the test reads intent, not implementation

That usually removes most flakiness without changing coverage.

[ekamwalia]

Hello @choo121600 ! I'd like to contribute to this issue.

@passionworkeer are your comments hard requirements for closing the issue or optional enhancements? Would like to split the work into PRs accordingly.

[choo121600]

Feel free to start working on it 😉

[haseebmalik18]

@ekamwalia Hey, are you still working on this?

[Rudrxxx]

Hi @choo121600, I’d like to work on this issue.

[ekamwalia]

Hey guys! I am still working in this issue. I am new to both this codebase and playwright so its taking me some time. Hoping to send a PR tomorrow!