You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A trigger's __init__ and serialize() are written as a pair: every __init__ parameter must appear in the serialize() return dict, otherwise it is silently dropped when the triggerer re-instantiates the trigger and falls back to the parameter's default. See deferring.rst.
The new check-trigger-serialize-init static check (added in #66960) flags this class of bug. It found 5 pre-existing genuine violations, which are currently allowlisted in KNOWN_VIOLATIONS in scripts/ci/prek/check_trigger_serialize_init.py so the check could be enabled. This issue tracks fixing them and removing them from the allowlist.
For each trigger below: add the missing parameter(s) to the serialize() return dict, add/extend a serialization unit test asserting the parameter round-trips, and remove the entry from KNOWN_VIOLATIONS.
Remove all fixed entries from KNOWN_VIOLATIONS in scripts/ci/prek/check_trigger_serialize_init.py (the set should end up empty)
Notes
These can be fixed individually (one PR per trigger / provider) or together. Note that BY_DESIGN_EXCLUSIONS in the same file is intentionally permanent and should not be touched — those cases (TimeDeltaTrigger, GKEJobTrigger, KubernetesJobTrigger) fold a deprecated/aliased parameter into its replacement at construction time and are correct as-is.
I’ll align each trigger’s serialize() return dict with its init parameters (adding any missing fields like caller / poll_interval / endpoint_prefix, storing values on self where needed) and add focused unit tests that round-trip serialize() --> **kwargs --> reinstantiation. Once the static check is clean, I’ll remove the corresponding entries from KNOWN_VIOLATIONS.
I’ll align each trigger’s serialize() return dict with its init parameters (adding any missing fields like caller / poll_interval / endpoint_prefix, storing values on self where needed) and add focused unit tests that round-trip serialize() --> **kwargs --> reinstantiation. Once the static check is clean, I’ll remove the corresponding entries from KNOWN_VIOLATIONS.
Picking up BigQueryIntervalCheckTrigger (the last of the five) — looks like @Nishieee has the other four covered in #66965 / #66966 / #66968 / and the Databricks Run trigger. Will keep the PR narrow to this single trigger and cross-reference #66960 so the KNOWN_VIOLATIONS entry can be removed from that side once both land.
Activity
Nishieee commentedon May 14, 2026
I’d love to work on this issue.
I’ll align each trigger’s serialize() return dict with its init parameters (adding any missing fields like caller / poll_interval / endpoint_prefix, storing values on self where needed) and add focused unit tests that round-trip serialize() --> **kwargs --> reinstantiation. Once the static check is clean, I’ll remove the corresponding entries from KNOWN_VIOLATIONS.
shahar1 commentedon May 14, 2026
Thank you, feel free to raise PRs.
abhid-007 commentedon May 15, 2026
Picking up
BigQueryIntervalCheckTrigger(the last of the five) — looks like @Nishieee has the other four covered in #66965 / #66966 / #66968 / and the Databricks Run trigger. Will keep the PR narrow to this single trigger and cross-reference #66960 so theKNOWN_VIOLATIONSentry can be removed from that side once both land.