Repository navigation
Connection support for repeated extra fields #9060
Description
Description
The Connection object should be able to support repeated keys in the extra fields.
Use case / motivation
Some connections strings, for instance the one used by MongoDB, support the repetition of keys such as in setting the rules for the precedence in choosing data-centres:
mongodb://mongos1.example.com,mongos2.example.com/?readPreference=secondary&readPreferenceTags=dc:ny,rack:r1&readPreferenceTags=dc:ny&readPreferenceTags=
At the moment, there is no way to set this in the Connection neither though the UI nor using the CLI.
>>> from airflow.models.connection import Connection
>>> c = Connection(uri='my-conn-type://my-login:my-password@my-host:5432/my-schema?param1=val1¶m2=val2')
>>> c.extra
'{"param1": "val1", "param2": "val2"}'
>>> c.set_extra('{"param1": "val1", "param1": "val2"}') # <- here
>>> c.get_uri()
'my-conn-type://my-login:my-password@my-host:5432/my-schema?param1=val2'
Adding support to this, maybe with an array form in the JSON would be ideal, i.e., being able to write something like:
>>> c.set_extra('{"param1": ["val1", "val2"]}')
>>> c.get_uri()
'my-conn-type://my-login:my-password@my-host:5432/my-schema?param1=val1¶m1=val2'
Activity
boring-cyborg commentedon May 29, 2020
Thanks for opening your first issue here! Be sure to follow the issue template!
mik-laj commentedon May 31, 2020
airflow/airflow/models/connection.py
Line 211 in ffbbbfc
If we want arrays to be created via the URL, we need to improve the parsing of the query string. Currently, you can only define a string there.
dstandish commentedon Apr 15, 2021
@frnidito we now can serialize full json to the conn URI (see #15100)
is it ok to close this issue?
github-actions commentedon Jun 20, 2021
This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author.
github-actions commentedon Jun 28, 2021
This issue has been closed because it has not received response from the issue author.