Skip to content

[ISSUE-18468] add container option for SparkKubernetesSensor - #18568

Closed
billstark wants to merge 1 commit into
apache:mainfrom
billstark:18468-fix-fetching-driver-logs-using-spark-kubernetes-sensor-with-side-car
Closed

billstark wants to merge 1 commit into
apache:mainfrom
billstark:18468-fix-fetching-driver-logs-using-spark-kubernetes-sensor-with-side-car

Conversation

@billstark

Copy link
Copy Markdown

…configure which container to retrieve logs


The problem with the current SparkKubernetesSensor is that, if the spark is running with sidecar containers for instance istio-proxy or vault-sidecar, which is rather common is some cases, the previous version cannot retrieve logs correctly and will run into errors.

A quick fix would be to add an option that allows developers to configure which container is the driver and can retrieve logs from driver container correctly.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

…configure which container to retrieve logs
@boring-cyborg boring-cyborg Bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers labels Sep 28, 2021
@boring-cyborg

boring-cyborg Bot commented Sep 28, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk

potiuk commented Sep 28, 2021

Copy link
Copy Markdown
Member

Could you please add appropriate test case for that?

@uranusjr

uranusjr commented Oct 7, 2021

Copy link
Copy Markdown
Member

Also, why is the current default value chosen? (The answer may be obvious but I know next to nothing about Spark and Kubernetes.)

@mik-laj

mik-laj commented Oct 7, 2021

Copy link
Copy Markdown
Member

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 22, 2021
@github-actions github-actions Bot closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants