Skip to content

Update code examples from "classic" operators to taskflow - #25657

Merged
uranusjr merged 13 commits into
apache:mainfrom
hankehly:issue-25319-hankehly-1
Aug 18, 2022
Merged

uranusjr merged 13 commits into
apache:mainfrom
hankehly:issue-25319-hankehly-1

Conversation

@hankehly

@hankehly hankehly commented Aug 11, 2022 •

Copy link
Copy Markdown
Contributor

Related: #25319

This PR replaces uses of PythonOperator with the @task TaskFlow decorator in faq, best practices and "index" documentation.

To view the updated docs in a browser:

  1. Build the docs
breeze build-docs --docs-only --package-filter apache-airflow
  1. Open docs/_build/docs/apache-airflow/latest/index.html in your browser

@hankehly
hankehly marked this pull request as ready for review August 11, 2022 05:17
@hankehly
hankehly requested review from kaxil and potiuk as code owners August 11, 2022 05:17
@hankehly

Copy link
Copy Markdown
Contributor Author

@josh-fell @potiuk
Please see this at your earliest convenience.
If it looks OK I'll go ahead and update the remaining docs in a separate PR.

@josh-fell josh-fell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for jumping in to update these! Just a few little comments.

Comment thread docs/apache-airflow/best-practices.rst Resolved
Comment thread docs/apache-airflow/best-practices.rst Resolved
Comment thread docs/apache-airflow/index.rst Resolved
hankehly and others added 2 commits August 16, 2022 08:47
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
@hankehly

Copy link
Copy Markdown
Contributor Author

@josh-fell Please see updates. I'll get started on the remaining files.

@uranusjr uranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor (non-blocking) comment

Comment thread docs/apache-airflow/faq.rst Resolved
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@josh-fell

Copy link
Copy Markdown
Contributor

@hankehly When you get a chance, can you address the static check errors please?

@uranusjr uranusjr changed the title Update code examples from "classic" operators to TaskFlow decorators (faq, best practices, index) Update code examples from "classic" operators to taskflow Aug 18, 2022
@uranusjr
uranusjr merged commit 98aac5d into apache:main Aug 18, 2022
@hankehly
hankehly deleted the issue-25319-hankehly-1 branch August 20, 2022 02:40
@jedcunningham jedcunningham added the type:doc-only Changelog: Doc Only label Sep 12, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants