Repository navigation

Fix `enable_logging=True` not working in `DockerSwarmOperator` - #35677

Merged

potiuk merged 10 commits into

apache:mainfrom

stavdav143:main

Dec 6, 2023

Merged

Fix `enable_logging=True` not working in `DockerSwarmOperator`#35677
potiuk merged 10 commits into
apache:mainfrom
stavdav143:main

Commits on Dec 6, 2023
- Fixes #28452: "TaskInstances do not succeed when using enable_logging=True option in DockerSwarmOperator"
  
  stavdav143
  authored and
  potiuk
  committed
  41966a7
- tty=True/False to be chosen by the user as it was the case before this fix (#28452)
  
  stavdav143
  authored and
  potiuk
  committed
  dcdbbce
- Follow=true for logs will always result in tasks not ending. This is standard and provided upstream by the Docker API.
  
  stavdav143
  authored and
  potiuk
  committed
  1c4422d
- service_logs called multiple times as we continuously poll the Docker API for logs. As we indicated in the previous commmit,
  
  stavdav143
  authored and
  potiuk
  committed
  6b445a3
- service_logs called multiple times. In this test the tasks increase (6 instead of 5) as we check if the service has terminated (+1). As this assertion makes less sense in a situation where we do mu…
  
  stavdav143
  authored and
  potiuk
  committed
  6f615d6
- Final commit of this PR marking the test case that validates logging in the Docker Swarm Operator. We log two times a different message and we assert that the two lines are given back in the logs i…
  
  stavdav143
  authored and
  potiuk
  committed
  ac8f4a9
- Formatting ruff
  
  stavdav143
  authored and
  potiuk
  committed
  2dc2813
- Reverting as Github actions don't run this test as a swarm node:
  
  stavdav143
  authored and
  potiuk
  committed
  965f6aa
- Logging "since" timestamp to avoid memory issues
  
  stavdav143
  authored and
  potiuk
  committed
  231e984
- Formatting - Fix for #28452
  
  stavdav143
  authored and
  potiuk
  committed
  b73bb50

Commits

Commits on Dec 6, 2023