Skip to content

Remove setting a non-existing object param and use local var instead in S3Hook #35950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hussein-awala merged 1 commit into from
Nov 29, 2023
Merged

Remove setting a non-existing object param and use local var instead in S3Hook #35950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow/providers/amazon/aws/hooks/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ def _is_in_period(input_date: datetime) -> bool:
_prefix = _original_prefix.split("*", 1)[0] if _apply_wildcard else _original_prefix
delimiter = delimiter or ""
start_after_key = start_after_key or ""
self.object_filter_usr = object_filter
object_filter_usr = object_filter
config = {
"PageSize": page_size,
"MaxItems": max_items,
Expand All @@ -827,8 +827,8 @@ def _is_in_period(input_date: datetime) -> bool:
if _apply_wildcard:
new_keys = (k for k in new_keys if fnmatch.fnmatch(k["Key"], _original_prefix))
keys.extend(new_keys)
if self.object_filter_usr is not None:
return self.object_filter_usr(keys, from_datetime, to_datetime)
if object_filter_usr is not None:
return object_filter_usr(keys, from_datetime, to_datetime)

return self._list_key_object_filter(keys, from_datetime, to_datetime)

Expand Down