Merged
Conversation
Taragolis
added
the
changelog:skip
Taragolis
requested review from
hussein-awala,
jedcunningham,
potiuk,
uranusjr and
vincbeck
boring-cyborg
bot
added
area:providers
provider:amazon
hussein-awala
approved these changes
Mar 4, 2024
eladkal
approved these changes
Mar 4, 2024
dirrao
approved these changes
Mar 4, 2024
vincbeck
approved these changes
Mar 4, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is pretty common mistake to use assert on non-existed
unittest.mock.Mockmethods.PGH005 might help to validate this methods, one downside is that it have false positive in some specific cases, see: astral-sh/ruff#10223 , this PR also cover this case
During the enable rule, I've found that some of the tests broken, maybe even initially or some kind of regression happen during the time.
I've marked this tests with
noqa: PGH005and have a plan to create a task for fix it^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.