Repository navigation
Implement card view for tasks view of a dag - #44604
Merged
Merged
Conversation
tirkarthi
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
December 3, 2024 11:58
bbovenzi
reviewed
Dec 3, 2024
bbovenzi
reviewed
Dec 3, 2024
bbovenzi
reviewed
Dec 3, 2024
tirkarthi
force-pushed
the
tasks-tab
branch
2 times, most recently
from
December 4, 2024 14:57
6335be3 to
3554cd1
Compare
bbovenzi
reviewed
Dec 4, 2024
bbovenzi
reviewed
Dec 4, 2024
bbovenzi
reviewed
Dec 4, 2024
bbovenzi
reviewed
Dec 5, 2024
bbovenzi
reviewed
Dec 5, 2024
Change Last Run to Last Instance in header name Use start date and wrap it with Time tag Show try number only when greater than 1 Use pluralize for task
bbovenzi
approved these changes
Dec 6, 2024
Contributor
Author
|
Thanks @bbovenzi |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Initial commit for tasks tab. * Remove unused columns for card view. * Fetch latest dag run and then fetch corresponding task instances. * Make font to be consistent. * Pass dagRunsLimit to limit the number of dagruns. * Add recent task instance plot to card. * Fix merge conflicts and use Status component. * Make task name bold Change Last Run to Last Instance in header name Use start date and wrap it with Time tag Show try number only when greater than 1 Use pluralize for task * Refactor tooltip to a separate component. Fix variable name casing. * Fix duration when null. * Use children prop to simplify TaskInstanceTooltip wrapping. * Omit content to reuse tooltip type.
1 of 2 tasks
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
tasksendpoint to fill the card view first. Get dag's recent dagruns and get the last dagrun id and pass it to taskinstances endpoint to get the last run and the corresponding task instance state.Comments for reviewers and self :
stateColorand the theme which will be fixed overall. Please let me know if I am missing some other configuration.This PR probably needs a rebase after #44269 is merged.