Skip to content

Remove pytest.mark.db_test where possible from asana provider #52093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 4 commits into from
Jun 23, 2025
Merged

Remove pytest.mark.db_test where possible from asana provider #52093

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3963519
Remove pytest.mark.db_test where possible from asana provider
yonghyeokrhee Jun 23, 2025
049986d
Merge branch 'main' into clean-db-test-flag-from-asana
yonghyeokrhee Jun 23, 2025
a4eda3c
Merge branch 'apache:main' into clean-db-test-flag-from-asana
yonghyeokrhee Jun 23, 2025
bc08daf
Update .pre-commit-config.yaml
potiuk Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ repos:
^providers/apache/beam/.*\.py$|
^providers/apache/flink/.*\.py$|
^providers/apache/iceberg/.*\.py$|
^providers/asana/.*\.py$|
Comment thread
potiuk marked this conversation as resolved.
Outdated
^providers/cloudant/.*\.py$|
^providers/cohere/.*\.py$|
^providers/common/compat/.*\.py$|
Expand Down
6 changes: 4 additions & 2 deletions providers/asana/tests/unit/asana/operators/test_asana_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
from airflow.utils import timezone

# The tests do not create dag runs, so db isolation tests are skipped
pytestmark = pytest.mark.db_test


DEFAULT_DATE = timezone.datetime(2015, 1, 1)
TEST_DAG_ID = "unit_test_dag"
Expand All @@ -52,6 +50,7 @@ def setup_connections(self, create_connection_without_db):
self.dag = dag
create_connection_without_db(Connection(conn_id="asana_test", conn_type="asana", password="test"))

@pytest.mark.db_test
@patch("airflow.providers.asana.hooks.asana.TasksApi", autospec=True, return_value=asana_tasks_api_mock)
def test_asana_create_task_operator(self, mock_tasks_api):
"""
Expand All @@ -69,6 +68,7 @@ def test_asana_create_task_operator(self, mock_tasks_api):
create_task.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
assert mock_tasks_api.return_value.create_task.called

@pytest.mark.db_test
@patch("airflow.providers.asana.hooks.asana.TasksApi", autospec=True, return_value=asana_tasks_api_mock)
def test_asana_find_task_operator(self, mock_tasks_api):
"""
Expand All @@ -84,6 +84,7 @@ def test_asana_find_task_operator(self, mock_tasks_api):
find_task.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
assert mock_tasks_api.return_value.get_tasks.called

@pytest.mark.db_test
@patch("airflow.providers.asana.hooks.asana.TasksApi", autospec=True, return_value=asana_tasks_api_mock)
def test_asana_update_task_operator(self, mock_tasks_api):
"""
Expand All @@ -99,6 +100,7 @@ def test_asana_update_task_operator(self, mock_tasks_api):
update_task.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
assert mock_tasks_api.return_value.update_task.called

@pytest.mark.db_test
@patch("airflow.providers.asana.hooks.asana.TasksApi", autospec=True, return_value=asana_tasks_api_mock)
def test_asana_delete_task_operator(self, mock_tasks_api):
"""
Expand Down
Loading